Ticket #236 (closed task: fixed)

Opened 14 months ago

Last modified 9 months ago

Remove the warnings for too many nodes

Reported by: faltet Owned by: somebody
Priority: major Component: PyTables
Version: 2.2 Keywords:
Cc: josh.moore@…

Description

After latest improvements in both HDF5 and PyTables, I think it has not much sense to keep warning users about too many nodes on a group or too many nested levels in the hierarchy.

Before doing this, one should benchmark that this is actually the case. If not, one can always increase MAX_GROUP_WIDTH and MAX_TREE_DEPTH instead.

Change History

Changed 14 months ago by josh

  • cc josh.moore@… added

Sorry for not having followed closely: the HDF5 and PyTables? changes don't also change the limits on the number of columns by any chance, do they?

Changed 14 months ago by faltet

Mmh, the warning in the number of columns is not related with the number of nodes. The rational about the warning is to prevent ending with too wide tables, that can limit the performance because they are saved row-wise. When/if column-wise tables would be implemented, I'd probably be able to raise this value much more (at least for column-wise tables).

Changed 14 months ago by josh

Understood and thanks. I didn't see a column-wise ticket, but if there is (ever) one, I'd be very interested. Cheers.

Changed 9 months ago by faltet

  • status changed from new to closed
  • resolution set to fixed

After some benchmarks, and despite the improvements, I think it is still safer to keep the warning. However, I've increased the number from 4096 to 16384 in r4293.

Closing this ticket.

Note: See TracTickets for help on using tickets.